Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: burn and mint #150

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat: burn and mint #150

merged 4 commits into from
Aug 6, 2024

Conversation

Daanvdplas
Copy link
Collaborator

Adds burn and mint to the fungibles use case.

Closes #98

@Daanvdplas Daanvdplas linked an issue Jul 31, 2024 that may be closed by this pull request
feat (pop api): add burn and mint to local fungibles use case #98
Closed
chungquantin
chungquantin requested changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@chungquantin chungquantin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed one line

#[test]
fn asset_exists_works() {
	new_test_ext().execute_with(|| {
-		create_asset(ALICE, ASSET, 100);
+ create_asset(ALICE, ASSET);
		assert_eq!(Assets::asset_exists(ASSET).encode(), Fungibles::read_state(AssetExists(ASSET)));
	});
}

@Daanvdplas Daanvdplas mentioned this pull request Aug 1, 2024
Open
16 tasks
peterwht
peterwht approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@peterwht peterwht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Small comment to create an issue to refactor some code in integration tests.

pop-api/integration-tests/src/fungibles/utils.rs Show resolved Hide resolved
@chungquantin chungquantin mentioned this pull request Aug 5, 2024
Closed
@Daanvdplas Daanvdplas merged commit 8816c3c into daan/feat-asset_management Aug 6, 2024
6 checks passed
@Daanvdplas Daanvdplas deleted the daan/feat-burning_and_minting branch August 6, 2024 08:21
@Daanvdplas Daanvdplas mentioned this pull request Aug 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chungquantin chungquantin chungquantin approved these changes

@peterwht peterwht peterwht approved these changes

Assignees
No one assigned
Labels
api Pop API pallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat (pop api): add burn and mint to local fungibles use case
3 participants
@Daanvdplas @peterwht @chungquantin